T-OAKM-add-the-s-0017-code-review-rubric-standard-and-the-judge
State: closed/done · Impact: medium · Complexity: medium
The plan’s phase gate calls for “the judgment judge workflow: verify changes plus a thorough code review with a fixed rubric,” but no rubric existed as a citable standard and no verb ran verify changes as a gate. Reviewers (human or agent) had no single source of truth for what “thorough” meant.
sdlc verify changes existed as a general-purpose changeset judge
against instruction files and standards, but nothing scoped it to
code-review criteria specifically, and sdlc.yaml had no judge verb.
Proposed
Section titled “Proposed”docs/planning/standards/S-0017-code-review-rubric.md states the
fixed rubric (functions, modularity, duplication, comments, structure,
naming, dead code, tests) as a standard verify changes can already
discover by scope. sdlc.yaml gains a judge verb:
bun solutions/ontological/cli/sdlc.ts verify changes --base main --blocking.
Approach
Section titled “Approach”- Wrote
S-0017-code-review-rubric.mdunderdocs/planning/standards/with the eight-criterion rubric and a scope covering the code under review. - Added the
judgeverb tosdlc.yaml’sverbs:map, runningverify changes --base main --blocking. - Confirmed
verify changespicks up S-0017 by scope when run against a sample changeset.
| Area | Note |
|---|---|
docs/planning/standards/S-0017-code-review-rubric.md | New standard |
sdlc.yaml | New judge verb |
Acceptance criteria
Section titled “Acceptance criteria”- AC-1: docs/planning/standards/S-0017-code-review-rubric.md exists and lists all eight rubric criteria named in the plan.
- AC-2: sdlc.yaml has a
judge:verb entry runningsdlc verify changes --base main --blocking. - AC-3:
sdlc verify changes --base mainincludes S-0017 among the standards it judges against for a change undersolutions/ontological/.
Out of scope
Section titled “Out of scope”- none
Dependencies
Section titled “Dependencies”- none