T-2YHP-app-state-overrides-follow-fleet

State: planning/proposed · Impact: medium · Complexity: medium

Goal

Some Determined state roots read their own env variable before fleet. While set, that variable wins over FLEET_ROOT, so one override no longer moves every root. Decide each variable’s fate so FLEET_ROOT alone isolates the app, as P-0017-scratch-root-isolation requires.

Today

Location	Role today
solutions/determined/crates/determined-core/src/models.rs	models_root() reads DETERMINED_MODELS_DIR first. The platform stamps it and NUXT_MODELS_DIR onto sidecars
solutions/determined/crates/determined-backup/src/config.rs	The store path reads VAULT_BACKUP_STORE first, relative to the repo root
solutions/determined/crates/determined-platform/src/services.rs	connector_pidfile() reads CONNECTOR_STATE_DIR first. apps/connector/src/paths.ts matches it
solutions/determined/crates/determined-platform/src/bin/platform-server.rs	--state-dir / PLATFORM_STATE_DIR move the settings and roster root
solutions/determined/tests/ui/harness/platform.ts	The e2e adapter unsets all of these, and GET /api/diagnostics/paths reports each resolved root, so the harness catches a leak

Proposed

Each variable is either removed, with its callers moved to FLEET_ROOT or FLEET_<HOME>_DIR, or kept with a written reason. A kept variable stays reported by the diagnostics endpoint.

Approach

1. List every reader of each variable, Rust and TS, including tests and docs.
2. Per variable, choose remove or keep. DETERMINED_MODELS_DIR points tests at a downloaded pack, so a FLEET_DURABLE_DIR replacement must still serve that case.
3. Remove the chosen variables and update their callers and docs.
4. Record the kept ones, with reasons, in S-0011-application-state-locations’s overrides section.

Areas

Area	Note
solutions/determined/crates/determined-core/	Models root
solutions/determined/crates/determined-backup/	Store path
solutions/determined/crates/determined-platform/	Connector dir, --state-dir, sidecar env
solutions/determined/apps/connector/	TS twin of the connector dir
docs/planning/standards/S-0011-application-state-locations.md	Kept overrides

Acceptance criteria

• AC-1: Each of DETERMINED_MODELS_DIR, NUXT_MODELS_DIR, VAULT_BACKUP_STORE, CONNECTOR_STATE_DIR and PLATFORM_STATE_DIR is removed or listed in S-0011 with a reason.
• AC-2: With only FLEET_ROOT set, every path GET /api/diagnostics/paths reports lies under the root, as platform_server_paths.rs asserts.

Out of scope

• SDF_FLEET_ROOT, which T-JPFC retires.

Dependencies

• none

Discovery context

• Review of the scratch-root e2e plan and harness found these variables unplanned.

---

← Back to Tasks