T-LCKH-sdlc-consumer-migration-detect-runners

State: closed/done · Impact: medium · Complexity: medium

Goal

Hard-cutover sdlc’s own consumers onto the now-consolidated @sksizer/detect-runners, and delete the sdlc-local files whose logic moved there in T-6K39: lib/config/detect-deps.ts, lib/config/pinned-manager.ts, and lib/services/project/detect-setup.ts. No aliases, no re-exports left behind at the old sdlc paths.

Today

lib/config/verbs.ts’s defaultSetup calls detectDeps/ resolvePinnedManagerInstall from the two sdlc-local files as its trailing fallback. lib/services/hooks/run.ts imports hasMissingDeps from @lib/config/detect-deps for its when: deps-missing hook condition. lib/services/config/ops/init.ts and lib/services/project/ops/setup.ts both import detectSetup from lib/services/project/detect-setup.ts, whose deps family delegates to detect-deps.ts and whose detectGitHooks/ detectToolTrust do their own from-scratch marker-file reads for a class of aspect detect-runners doesn’t detect at all today.

Proposed

lib/config/detect-deps.ts and lib/config/pinned-manager.ts are deleted; every caller imports resolveInstall/hasMissingDeps/missingDeps/ resolvePinnedManagerInstall from @sksizer/detect-runners instead.
lib/services/project/detect-setup.ts is deleted; its deps family becomes a call to @sksizer/detect-runners’s resolveInstall; its detectGitHooks/detectToolTrust become direct reads of AspectFacts.hookManagers/.toolTrust off collectAspects().
defaultSetup (verbs.ts) calls the same consolidated functions, unchanged behavior.

Approach

Update verbs.ts’s defaultSetup to import resolveInstall/ resolvePinnedManagerInstall from @sksizer/detect-runners; delete its own imports of the sdlc-local files.
Update hooks/run.ts’s when: deps-missing condition to import hasMissingDeps from @sksizer/detect-runners.
Rewrite config/ops/init.ts and project/ops/setup.ts to call resolveInstall and read AspectFacts.hookManagers/.toolTrust directly (via collectAspects), replacing their detectSetup import.
Delete lib/config/detect-deps.ts, lib/config/pinned-manager.ts, lib/services/project/detect-setup.ts and their test files (behavior moves to detect-runners’s own test suite from T-6K39).
Grep sweep: grep -rn "detect-deps\|pinned-manager\|project/detect-setup" solutions/ontological returns nothing outside historical decision-doc prose.

Areas

Area	Note
`solutions/ontological/lib/config/verbs.ts`	`defaultSetup` imports from `@sksizer/detect-runners`
`solutions/ontological/lib/config/detect-deps.ts`, `pinned-manager.ts`	Deleted
`solutions/ontological/lib/services/project/detect-setup.ts`	Deleted
`solutions/ontological/lib/services/hooks/run.ts`	`hasMissingDeps` import swap
`solutions/ontological/lib/services/config/ops/init.ts`, `lib/services/project/ops/setup.ts`	`detectSetup` import replaced

Acceptance criteria

AC-1: bun test solutions/ontological/lib/{config,services/project,services/hooks,services/config} passes.
AC-2: defaultSetup('setup', root)’s observable output (the resolved setup command list) is byte-for-byte identical before and after this task, for every fixture the current verbs.test.ts exercises. — SUPERSEDED, not failed: defaultSetup itself was retired outright by T-VE84 rather than carried forward to compare against; see completion_note.
AC-3: sdlc init and sdlc project setup --detect produce identical output to today for the repo’s own fixtures (covered by setup-candidates.test.ts/init_op.test.ts, both green above).
AC-4: grep -rn "detect-deps\|pinned-manager\|detect-setup" solutions/ontological docs (excluding docs/planning/decisions/) returns nothing outside historical task/milestone prose describing this migration and the intentionally-kept sdlc project detect-setup CLI command name.

Out of scope

Rewiring resolveVerb’s ~10 other direct callers (that’s T-YZOM — unrelated to detection; defaultSetup/hooks/run.ts/init.ts/setup.ts above are the only detection-specific ones).
manifest-graph/project-facets.get.ts adoption — T-3GMU/T-OUKL.

Dependencies

T-6K39 (needs the moved/rewired resolveInstall/hasMissingDeps/ resolvePinnedManagerInstall to already exist in @sksizer/detect-runners).

Discovery context

Detection-consolidation research: ../decisions/D-LSLH-collapse-verbs-workflows-chain-hooks/detection-consolidation.md §4 “What gets deleted”, §5 “Migration map”.

Depends on

T-6K39

← Back to Tasks